Support canonical EP names in SessionOptionsAppendExecutionProvider#24433
Merged
adrianlizarraga merged 10 commits intomainfrom Apr 16, 2025
Merged
Support canonical EP names in SessionOptionsAppendExecutionProvider#24433adrianlizarraga merged 10 commits intomainfrom
adrianlizarraga merged 10 commits intomainfrom
Conversation
adrianlizarraga
commented
Apr 15, 2025
skottmckay
previously approved these changes
Apr 16, 2025
adrianlizarraga
commented
Apr 16, 2025
skottmckay
approved these changes
Apr 16, 2025
fs-eire
pushed a commit
that referenced
this pull request
Apr 16, 2025
### Description Fix compilation issue (undeclared identifier) in Azure EP unit test. ### Motivation and Context A previous PR caused a compilation issue in the Azure EP unit test: #24433 Our PR CI pipelines did not catch it. It was caught by our post-merge packaging pipelines. ```shell D:\a\_work\1\s\onnxruntime\test\providers\azure\azure_basic_test.cc(28,3): error C2065: 'session_options': undeclared identifier [D:\a\_work\1\b\RelWithDebInfo\onnxruntime_test_all.vcxproj] D:\a\_work\1\s\onnxruntime\test\providers\azure\azure_basic_test.cc(29,3): error C2065: 'session_options': undeclared identifier [D:\a\_work\1\b\RelWithDebInfo\onnxruntime_test_all.vcxproj] D:\a\_work\1\s\onnxruntime\test\providers\azure\azure_basic_test.cc(30,3): error C2065: 'session_options': undeclared identifier [D:\a\_work\1\b\RelWithDebInfo\onnxruntime_test_all.vcxproj] ```
ashrit-ms
pushed a commit
that referenced
this pull request
Apr 24, 2025
…24433) ### Description Updates the `SessionOptionsAppendExecutionProvider` function to also support full canonical provider names (e.g., QNNExecutionProvider) in addition to the short names (e.g., QNN). ### Motivation and Context There's an inconsistency in how ORT names EPs. The `SessionOptionsAppendExecutionProvider` C API function uses short names (e.g., "QNN"), but other ORT APIs use longer names (e.g., "QNNExecutionProvider"). - Python APIs to add EP to session uses "QNNExecutionProvider" (not "QNN") - Python and C APIs to GetAvailableProviders use "QNNExecutionProvider" - Internal ORT code uses "QNNExecutionProvider" to assign nodes to cuda ep. - Only `SessionOptionsAppendExecutionProvider` uses short names like "QNN".
ashrit-ms
pushed a commit
that referenced
this pull request
Apr 24, 2025
### Description Fix compilation issue (undeclared identifier) in Azure EP unit test. ### Motivation and Context A previous PR caused a compilation issue in the Azure EP unit test: #24433 Our PR CI pipelines did not catch it. It was caught by our post-merge packaging pipelines. ```shell D:\a\_work\1\s\onnxruntime\test\providers\azure\azure_basic_test.cc(28,3): error C2065: 'session_options': undeclared identifier [D:\a\_work\1\b\RelWithDebInfo\onnxruntime_test_all.vcxproj] D:\a\_work\1\s\onnxruntime\test\providers\azure\azure_basic_test.cc(29,3): error C2065: 'session_options': undeclared identifier [D:\a\_work\1\b\RelWithDebInfo\onnxruntime_test_all.vcxproj] D:\a\_work\1\s\onnxruntime\test\providers\azure\azure_basic_test.cc(30,3): error C2065: 'session_options': undeclared identifier [D:\a\_work\1\b\RelWithDebInfo\onnxruntime_test_all.vcxproj] ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the
SessionOptionsAppendExecutionProviderfunction to also support full canonical provider names (e.g., QNNExecutionProvider) in addition to the short names (e.g., QNN).Motivation and Context
There's an inconsistency in how ORT names EPs. The
SessionOptionsAppendExecutionProviderC API function uses short names (e.g., "QNN"), but other ORT APIs use longer names (e.g., "QNNExecutionProvider").SessionOptionsAppendExecutionProvideruses short names like "QNN".