Rename matmul_4bits_quantizer.py to matmul_nbits_quantizer.py#24472
Merged
Rename matmul_4bits_quantizer.py to matmul_nbits_quantizer.py#24472
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tianleiwu
force-pushed
the
tlwu/rename_nbits_quantizier
branch
from
459307e to
538309d
Compare
kunal-vaishnavi
approved these changes
Apr 19, 2025
jiafatom
reviewed
Apr 19, 2025
Contributor
jiafatom
left a comment
jiafatom
left a comment
There was a problem hiding this comment.
Can we rename matmul_4bits_quantizer.py to matmul_quantizer.py? Previously we have 4 bits only, so we add 4bits in between. It seems a matmul_quantizer to me
Contributor
Author
nbits naming follows MatMulNBits op. |
6 tasks
xiaoyu-work
pushed a commit
to microsoft/Olive
that referenced
this pull request
Apr 23, 2025
## Describe your changes onnxruntime uses MatMulNBitsQuantizer since 1.22.0, due to microsoft/onnxruntime#24472 ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
xiaoyu-work
pushed a commit
to microsoft/Olive
that referenced
this pull request
Apr 23, 2025
## Describe your changes onnxruntime uses MatMulNBitsQuantizer since 1.22.0, due to microsoft/onnxruntime#24472 ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
ashrit-ms
pushed a commit
that referenced
this pull request
Apr 24, 2025
### Description * Rename filename and class name since it supports 4 and 8 bits. * Update HQQWeightOnlyQuantizer to support 8 bits. * Update some comments. ### Motivation and Context #24384 added 8 bits support for the default weight only quantizer.
intbf
pushed a commit
to intbf/onnxruntime
that referenced
this pull request
Apr 25, 2025
…oft#24472) ### Description * Rename filename and class name since it supports 4 and 8 bits. * Update HQQWeightOnlyQuantizer to support 8 bits. * Update some comments. ### Motivation and Context microsoft#24384 added 8 bits support for the default weight only quantizer. Signed-off-by: bfilipek <bartlomiej.filipek@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
#24384 added 8 bits support for the default weight only quantizer.