Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
Somehow all my PRs stuck in the license/cla check |
Contributor
Author
|
@microsoft-github-policy-service rerun |
snnn
force-pushed
the
snnn/trigger4
branch
5 times, most recently
from
f9f46cb to
99d6d91
Compare
Contributor
Author
|
I reverted some changes now CLA can pass. It is very strange. |
jchen351
approved these changes
Apr 25, 2025
Contributor
Author
|
@fs-eire It works! |
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
May 12, 2025
### Description
1. Update Github Actions pipelines' triggers. Make all of them to be the
same.
2. Format yaml files.
Before this change, the pipelines' triggers were set as following:
```
on:
push:
branches: [ main, 'rel-*']
pull_request:
branches: [ main, 'rel-*']
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
```
I set "cancel-in-progress: true" because for pipeline runs triggered by
pull requests if the pull request was updated(a new commit was added
there), the old pipeline runs can be cancelled. However, this setting
doesn't work well for the runs triggered by "push" events for the main
branch. Let's say, we merged a PR , then it triggered this pipeline.
Then before the pipeline is finished, we merged another PR. Then the old
pipeline run will be cancelled. But we do want it to be cancelled. Each
commit in the main branch should be verified.
### Motivation and Context
snnn
pushed a commit
that referenced
this pull request
May 15, 2025
This PR is a follow-up of #24547 . Previously the pipelines had some issues that prevented me to modify these files. Now the issue is solved.
snnn
pushed a commit
to microsoft/onnxruntime-genai
that referenced
this pull request
May 19, 2025
### Description
1. Update Github Actions pipelines' triggers. Make all of them to be the
same(The same as the ORT main repo's setting)
2. Format yaml files.
Before this change, the pipelines' triggers were set as following:
```
on:
push:
branches: [ main, 'rel-*']
pull_request:
branches: [ main, 'rel-*']
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
```
I set "cancel-in-progress: true" because for pipeline runs triggered by
pull requests if the pull request was updated(a new commit was added
there), the old pipeline runs can be cancelled. However, this setting
doesn't work well for the runs triggered by "push" events for the main
branch. Let's say, we merged a PR , then it triggered this pipeline.
Then before the pipeline is finished, we merged another PR. Then the old
pipeline run will be cancelled. But we do want it to be cancelled. Each
commit in the main branch should be verified.
### Motivation and Context
See: microsoft/onnxruntime#24547
ajindal1
pushed a commit
to microsoft/onnxruntime-genai
that referenced
this pull request
Jun 3, 2025
### Description
1. Update Github Actions pipelines' triggers. Make all of them to be the
same(The same as the ORT main repo's setting)
2. Format yaml files.
Before this change, the pipelines' triggers were set as following:
```
on:
push:
branches: [ main, 'rel-*']
pull_request:
branches: [ main, 'rel-*']
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
```
I set "cancel-in-progress: true" because for pipeline runs triggered by
pull requests if the pull request was updated(a new commit was added
there), the old pipeline runs can be cancelled. However, this setting
doesn't work well for the runs triggered by "push" events for the main
branch. Let's say, we merged a PR , then it triggered this pipeline.
Then before the pipeline is finished, we merged another PR. Then the old
pipeline run will be cancelled. But we do want it to be cancelled. Each
commit in the main branch should be verified.
### Motivation and Context
See: microsoft/onnxruntime#24547
adrianlizarraga
pushed a commit
that referenced
this pull request
Aug 5, 2025
This PR is a follow-up of #24547 . Previously the pipelines had some issues that prevented me to modify these files. Now the issue is solved.
quic-ankus
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Nov 25, 2025
This PR is a follow-up of microsoft#24547 . Previously the pipelines had some issues that prevented me to modify these files. Now the issue is solved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this change, the pipelines' triggers were set as following:
I set "cancel-in-progress: true" because for pipeline runs triggered by pull requests if the pull request was updated(a new commit was added there), the old pipeline runs can be cancelled. However, this setting doesn't work well for the runs triggered by "push" events for the main branch. Let's say, we merged a PR , then it triggered this pipeline. Then before the pipeline is finished, we merged another PR. Then the old pipeline run will be cancelled. But we do want it to be cancelled. Each commit in the main branch should be verified.
Motivation and Context