[QNN-EP] Minor fix: compare different types#24550
Merged
HectorSVC merged 1 commit intomicrosoft:mainfrom Apr 29, 2025
Merged
Conversation
1duo
changed the title
Contributor
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
Contributor
Author
|
Hi @snnn, thanks for helping with starting the CI! I'm new to this project, could you help to check if the CI failure is related? If so, could you point me to the details I should pay attention to? If not, would we able to re-trigger the failed one? |
Contributor
Author
|
/azp run Windows ARM64 QNN CI Pipeline |
|
Commenter does not have sufficient privileges for PR 24550 in repo microsoft/onnxruntime |
Contributor
|
/azp run Linux QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows ARM64 QNN CI Pipeline,Linux Android Emulator QNN CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
HectorSVC
approved these changes
Apr 29, 2025
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
May 12, 2025
Fix:
```/local/mnt/workspace/onnxruntime-qnn-ep/onnxruntime/core/providers/qnn/builder/opbuilder/softmax_op_builder.cc:
In function ‘std::vector<unsigned int>
onnxruntime::qnn::FlattenShapeFromAxis(std::vector<unsigned int>&,
int32_t)’:
/local/mnt/workspace/onnxruntime-qnn-ep/onnxruntime/core/providers/qnn/builder/opbuilder/softmax_op_builder.cc:47:28:
error: comparison of integer expressions of different signedness:
‘int32_t’ {aka ‘int’} and ‘std::vector<unsigned int>::size_type’ {aka
‘long unsigned int’} [-Werror=sign-compare]
47 | assert(axis >= 0 && axis < input_shape.size());
|```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
/local/mnt/workspace/onnxruntime-qnn-ep/onnxruntime/core/providers/qnn/builder/opbuilder/softmax_op_builder.cc: In function ‘std::vector<unsigned int> onnxruntime::qnn::FlattenShapeFromAxis(std::vector<unsigned int>&, int32_t)’: /local/mnt/workspace/onnxruntime-qnn-ep/onnxruntime/core/providers/qnn/builder/opbuilder/softmax_op_builder.cc:47:28: error: comparison of integer expressions of different signedness: ‘int32_t’ {aka ‘int’} and ‘std::vector<unsigned int>::size_type’ {aka ‘long unsigned int’} [-Werror=sign-compare] 47 | assert(axis >= 0 && axis < input_shape.size()); |