Conversation
… suggestions for comments
edgchen1
reviewed
May 2, 2025
onnxruntime/core/providers/coreml/builders/impl/base_op_builder.h
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/conv_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/conv_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
May 24, 2025
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/base_op_builder.h
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/base_op_builder.cc
Outdated
Show resolved
Hide resolved
… added documentation + explanation for the negative one collisions check
skottmckay
reviewed
May 29, 2025
onnxruntime/core/providers/coreml/builders/impl/conv_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
May 31, 2025
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/softmax_op_builder.cc
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
Jun 4, 2025
onnxruntime/core/providers/coreml/builders/impl/conv_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/softmax_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
Jun 5, 2025
onnxruntime/core/providers/coreml/builders/impl/reshape_op_builder.cc
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
Jun 5, 2025
edgchen1
approved these changes
Jun 6, 2025
carzh
changed the title
tianleiwu
reviewed
Jun 7, 2025
| } | ||
|
|
||
| bool SoftmaxOpBuilder::IsOpSupportedImpl(const Node& node, const OpBuilderInputParams& /*input_params*/, | ||
| bool SoftmaxOpBuilder::IsOpSupportedImpl(const Node& node, const OpBuilderInputParams& input_params, |
Contributor
There was a problem hiding this comment.
input_params is not used. There is build warnings.
javier-intel
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Jun 15, 2025
### Description Moved the dimension limit because it seems to only apply to conv operations (texture memory is typically used for conv operations in the GPU because it has a slow write but fast read -- ChromaDB model had a slice operation with an input > 16384 -- operation worked fine after I had moved the dim check) Also added extra checks for Softmax on MLProgram that allows more softmax nodes to be moved to CoreML
quic-ankus
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Nov 25, 2025
### Description Moved the dimension limit because it seems to only apply to conv operations (texture memory is typically used for conv operations in the GPU because it has a slow write but fast read -- ChromaDB model had a slice operation with an input > 16384 -- operation worked fine after I had moved the dim check) Also added extra checks for Softmax on MLProgram that allows more softmax nodes to be moved to CoreML
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moved the dimension limit because it seems to only apply to conv operations (texture memory is typically used for conv operations in the GPU because it has a slow write but fast read -- ChromaDB model had a slice operation with an input > 16384 -- operation worked fine after I had moved the dim check)
Also added extra checks for Softmax on MLProgram that allows more softmax nodes to be moved to CoreML