Integration with ONNX 1.18.0#24945
Merged
titaiwangms merged 6 commits intomicrosoft:mainfrom Jun 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the ONNX submodule and port definitions to integrate ONNX version 1.18.0.
- Bump ONNX commit reference and checksum in vcpkg portfile
- Update external subproject commit pointer
- Change dependency URL in
deps.txtto the v1.18.0 release
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmake/vcpkg-ports/onnx/portfile.cmake | Updated REF and SHA512 for ONNX v1.18.0 |
| cmake/external/onnx | Point subproject commit to new ONNX hash |
| cmake/deps.txt | Switched ONNX entry to use v1.18.0 release URL |
Comments suppressed due to low confidence (2)
cmake/vcpkg-ports/onnx/portfile.cmake:8
- Verify that the existing patches (
fix-cmakelists.patch,fix-dependency-protobuf.patch) still apply cleanly to ONNX v1.18.0; if not, update them to avoid build failures.
PATCHES
cmake/vcpkg-ports/onnx/portfile.cmake:6
- It looks like the ONNX version was bumped but the port's CONTROL (or manifest) file version wasn’t updated—please increment the port version to 1.18.0 so vcpkg accurately reflects this change.
REF e709452ef2bbc1d113faf678c24e6d3467696e83
justinchuby
approved these changes
Jun 10, 2025
xadupre
approved these changes
Jun 10, 2025
javier-intel
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Jun 15, 2025
Follow up microsoft#24449 This PR integrates with ONNX 1.18.0.
6 tasks
|
👋 any chance of cutting a new release for this change? Thanks! |
Contributor
Author
|
cc @MaanavD |
Contributor
|
Hey @chenrui333, We'll have this as a part of 1.23, released at the end of July. Otherwise, if you really needed a patch release for some reason, feel free to reach out. |
|
yeah, I was trying to bump onnx to 1.18.0, but it does not work with onnxruntime (so need a patch or a new release to see how it can work it) |
5 tasks
quic-ankus
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Nov 25, 2025
Follow up microsoft#24449 This PR integrates with ONNX 1.18.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #24449
This PR integrates with ONNX 1.18.0.