Add RotaryEmbeddings(23) - CPU#24980
Merged
titaiwangms merged 10 commits intomicrosoft:mainfrom Jun 25, 2025
Merged
Conversation
gramalingam
reviewed
Jun 16, 2025
Contributor
Author
|
@tianleiwu Could you help me reason the CI failing? It seems the code only fails on Windows Asan |
Contributor
|
@titaiwangms, the code crashed (maybe there is bug in either test code or the kernel): [ RUN ] RotaryEmbeddingTest.RotaryEmbedding_Interleaved_NoPosIds_SmallData_LlamaMSFT Could you review the test case setup and the kernel code? |
tianleiwu
reviewed
Jun 18, 2025
tianleiwu
reviewed
Jun 18, 2025
tianleiwu
reviewed
Jun 18, 2025
tianleiwu
reviewed
Jun 18, 2025
tianleiwu
reviewed
Jun 19, 2025
tianleiwu
reviewed
Jun 19, 2025
tianleiwu
reviewed
Jun 19, 2025
tianleiwu
reviewed
Jun 19, 2025
tianleiwu
reviewed
Jun 19, 2025
tianleiwu
reviewed
Jun 19, 2025
tianleiwu
reviewed
Jun 19, 2025
tianleiwu
reviewed
Jun 19, 2025
tianleiwu
reviewed
Jun 21, 2025
xadupre
reviewed
Jun 24, 2025
xadupre
reviewed
Jun 24, 2025
xadupre
reviewed
Jun 24, 2025
Contributor
Author
|
@tianleiwu @gramalingam @xadupre PTAL |
tianleiwu
approved these changes
Jun 25, 2025
titaiwangms
added a commit
that referenced
this pull request
Jul 7, 2025
Follow up #24980 Fix #24556 Add ONNX RotaryEmbedding(23) following https://github.com/onnx/onnx/blob/main/docs/Operators.md#RotaryEmbedding. The PR uses contrib op RotaryEmbedding implementation under the hood. The main difference between this op and the contrib op is that the position_ids in ONNX RotaryEmbedding is optional. When it's not provided, cos_cache and sin_cache should be 3d.
daijh
pushed a commit
to daijh/onnxruntime
that referenced
this pull request
Jul 10, 2025
Follow up microsoft#24980 Fix microsoft#24556 Add ONNX RotaryEmbedding(23) following https://github.com/onnx/onnx/blob/main/docs/Operators.md#RotaryEmbedding. The PR uses contrib op RotaryEmbedding implementation under the hood. The main difference between this op and the contrib op is that the position_ids in ONNX RotaryEmbedding is optional. When it's not provided, cos_cache and sin_cache should be 3d.
qti-yuduo
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Aug 8, 2025
Follow up microsoft#24980 Fix microsoft#24556 Add ONNX RotaryEmbedding(23) following https://github.com/onnx/onnx/blob/main/docs/Operators.md#RotaryEmbedding. The PR uses contrib op RotaryEmbedding implementation under the hood. The main difference between this op and the contrib op is that the position_ids in ONNX RotaryEmbedding is optional. When it's not provided, cos_cache and sin_cache should be 3d.
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
Follow up microsoft#24980 Fix microsoft#24556 Add ONNX RotaryEmbedding(23) following https://github.com/onnx/onnx/blob/main/docs/Operators.md#RotaryEmbedding. The PR uses contrib op RotaryEmbedding implementation under the hood. The main difference between this op and the contrib op is that the position_ids in ONNX RotaryEmbedding is optional. When it's not provided, cos_cache and sin_cache should be 3d.
quic-ankus
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Nov 25, 2025
### Description <!-- Describe your changes. --> Add ONNX RotaryEmbedding(23) following https://github.com/onnx/onnx/blob/main/docs/Operators.md#RotaryEmbedding. The PR uses contrib op RotaryEmbedding implementation under the hood. The main difference between this op and the contrib op is that the `position_ids` in ONNX RotaryEmbedding is optional. When it's not provided, `cos_cache` and `sin_cache` should be 3d. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Fix microsoft#24556 Reference microsoft#23507
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add ONNX RotaryEmbedding(23) following https://github.com/onnx/onnx/blob/main/docs/Operators.md#RotaryEmbedding. The PR uses contrib op RotaryEmbedding implementation under the hood.
The main difference between this op and the contrib op is that the
position_idsin ONNX RotaryEmbedding is optional. When it's not provided,cos_cacheandsin_cacheshould be 3d.Motivation and Context
Fix #24556
Reference #23507