Skip to content

Integrate ACL EP into the build script#2511

Closed
mikecaraman wants to merge 1 commit intomicrosoft:masterfrom
mikecaraman:acl_build_improvements
Closed

Integrate ACL EP into the build script#2511
mikecaraman wants to merge 1 commit intomicrosoft:masterfrom
mikecaraman:acl_build_improvements

Conversation

@mikecaraman
Copy link
Contributor

Integrate ACL EP into the build script and expose ACL_1902 compile option.

The build was validated with the following commands:

$ export CMAKE_ARGS="-DONNX_CUSTOM_PROTOC_EXECUTABLE=/PROTOC_PATH/protoc"
$ ../onnxruntime-arm-upstreamv2/build.sh --path_to_protoc_exe /PROTOC_PATH/protoc --config RelWithDebInfo
--use_acl=ACL_1902 --build_shared_lib --use_openmp --update
$ ../onnxruntime-arm-upstreamv2/build.sh --path_to_protoc_exe /PROTOC_PATH/protoc --config RelWithDebInfo
--use_acl=ACL_1902 --build_shared_lib --use_openmp --build --parallel

Description: Describe your changes.

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

@mikecaraman mikecaraman requested a review from a team as a code owner November 28, 2019 11:42
@HectorSVC
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 12 pipeline(s).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be able to build with build.bat or build.sh directly instead of the long cmake command, refers to the OpenVINO one:
https://github.com/microsoft/onnxruntime/blob/master/BUILD.md#openvino

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_onnxruntime_tests [](start = 8, length = 21)

should you update the definition for run_onnxruntime_tests?

Integrate ACL EP into the build script and expose ACL_1902 compile option.

The build was validated with the following commands:

$ export CMAKE_ARGS="-DONNX_CUSTOM_PROTOC_EXECUTABLE=/PROTOC_PATH/protoc"
$ ../onnxruntime-arm-upstreamv2/build.sh --path_to_protoc_exe /PROTOC_PATH/protoc --config RelWithDebInfo
  --use_acl=ACL_1902 --build_shared_lib --use_openmp --update --build --parallel
@mikecaraman mikecaraman force-pushed the acl_build_improvements branch from 19a2259 to f71e2c1 Compare December 7, 2019 07:39
@jywu-msft
Copy link
Member

pinging this PR. are we still trying to merge this into master? looks like there are conflicts which need to be resolved.

@stale
Copy link

stale bot commented Jul 3, 2020

This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@stale stale bot added the wontfix label Jul 3, 2020
@stale
Copy link

stale bot commented Jul 11, 2020

This issue has been automatically closed due to inactivity. Please reactivate if further support is needed.

@stale stale bot closed this Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants