Skip to content

[webgpu] Apply template to MatMulNBitsWideTile#25353

Merged
fs-eire merged 11 commits intomicrosoft:mainfrom
daijh:apply-template-matmul
Jul 16, 2025
Merged

[webgpu] Apply template to MatMulNBitsWideTile#25353
fs-eire merged 11 commits intomicrosoft:mainfrom
daijh:apply-template-matmul

Conversation

@daijh
Copy link
Contributor

@daijh daijh commented Jul 10, 2025

Description

This commit applies WGSL template to MatMulNBitsWideTile to improve code readability and enables more flexible data handling.

As part of this change, support for 4-bit and 8-bit shaders has been consolidated, and a common CEIL_DIV utility has been introduced. The previous ShaderUsage::UseUniform and ShaderUsage::UseIndicesTypeAlias flags are no longer necessary and have been removed.

Motivation and Context

See above

@daijh daijh marked this pull request as draft July 10, 2025 01:13
@daijh daijh marked this pull request as ready for review July 10, 2025 03:39
@daijh
Copy link
Contributor Author

daijh commented Jul 10, 2025

@fs-eire @qjia7 please take a look.

@daijh daijh changed the title [webgpu] Apply template to MatMulNBitsWideTileProgram [webgpu] Apply template to MatMulNBitsWideTile Jul 10, 2025
@daijh daijh force-pushed the apply-template-matmul branch from 9ab288f to d6abdb3 Compare July 11, 2025 02:20
qjia7
qjia7 previously approved these changes Jul 11, 2025
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@fs-eire
Copy link
Contributor

fs-eire commented Jul 11, 2025

/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@fs-eire
Copy link
Contributor

fs-eire commented Jul 14, 2025

/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@daijh
Copy link
Contributor Author

daijh commented Jul 15, 2025

@fs-eire
Fixed the Linux compiler complaint.

@fs-eire
Copy link
Contributor

fs-eire commented Jul 15, 2025

/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@fs-eire fs-eire merged commit 58954ba into microsoft:main Jul 16, 2025
87 checks passed
@daijh daijh deleted the apply-template-matmul branch July 17, 2025 03:21
qti-yuduo pushed a commit to CodeLinaro/onnxruntime that referenced this pull request Aug 8, 2025
### Description
This commit applies WGSL template to `MatMulNBitsWideTile` to improve
code readability and enables more flexible data handling.

As part of this change, support for 4-bit and 8-bit shaders has been
consolidated, and a common `CEIL_DIV` utility has been introduced. The
previous `ShaderUsage::UseUniform` and
`ShaderUsage::UseIndicesTypeAlias` flags are no longer necessary and
have been removed.

### Motivation and Context
See above
sanketkaleoss pushed a commit to sanketkaleoss/onnxruntime that referenced this pull request Aug 11, 2025
### Description
This commit applies WGSL template to `MatMulNBitsWideTile` to improve
code readability and enables more flexible data handling.

As part of this change, support for 4-bit and 8-bit shaders has been
consolidated, and a common `CEIL_DIV` utility has been introduced. The
previous `ShaderUsage::UseUniform` and
`ShaderUsage::UseIndicesTypeAlias` flags are no longer necessary and
have been removed.

### Motivation and Context
See above
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants