Skip to content

POWER : Implement MlasGemmQuantKernel using VSX builtins for M = 1#25490

Merged
hariharans29 merged 3 commits intomicrosoft:mainfrom
BODAPATIMAHESH:main_gemv
Sep 3, 2025
Merged

POWER : Implement MlasGemmQuantKernel using VSX builtins for M = 1#25490
hariharans29 merged 3 commits intomicrosoft:mainfrom
BODAPATIMAHESH:main_gemv

Conversation

@BODAPATIMAHESH
Copy link
Contributor

POWER : Added a VSX-based implementation of MlasGemmQuantKernel optimized for the case when M = 1.
Verified correctness using ONNX Runtime's built-in tests and onnxruntime_mlas_tests;no regressions observed.
Evaluated performance using a Granite 8-bit quantized model and observed approximately 3-5% improvement in token generation speed.

Description

when M=1 then performed a multiplication using a VSX vector builtin vec_msum

Motivation and Context

To improve token generation performance for models with a batch size of 1

@BODAPATIMAHESH BODAPATIMAHESH marked this pull request as draft July 31, 2025 06:19
@BODAPATIMAHESH BODAPATIMAHESH marked this pull request as ready for review August 2, 2025 03:31
@BODAPATIMAHESH
Copy link
Contributor Author

@yufenglee Could you review this PR.

@BODAPATIMAHESH
Copy link
Contributor Author

BODAPATIMAHESH commented Aug 5, 2025

@BODAPATIMAHESH please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree company="IBM"

@hariharans29
Copy link
Member

/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@hariharans29
Copy link
Member

/azp run Build Linux arm64 Debug / build_test_pipeline, Build Linux arm64 Release / build_test_pipeline, Build Linux CUDA x64 Release / build_test_pipeline, Build Linux CUDA x64 Release / build_test_pipeline, Build Linux TensorRT x64 Release / build_test_pipeline, Build Linux x64 Debug (ASan) / build_test_pipeline, Build and Test OpenVINO EP

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@hariharans29
Copy link
Member

/azp run Build and Test OpenVINO EP, build_x64_debug

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@hariharans29 hariharans29 requested a review from Copilot August 12, 2025 05:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a specialized VSX-based implementation of MlasGemmQuantKernel optimized for the M=1 case to improve token generation performance for models with batch size 1, achieving a 3-5% improvement.

Key changes:

  • Added M=1 optimization in packing function for improved memory layout
  • Implemented specialized MlasGemmQuantKernel_M1 function using VSX vector multiplication
  • Modified main kernel function to route M=1 cases to the optimized implementation

@fs-eire
Copy link
Contributor

fs-eire commented Aug 12, 2025

Try close & reopen to trigger the checks

@fs-eire fs-eire closed this Aug 12, 2025
@fs-eire fs-eire reopened this Aug 12, 2025
@hariharans29
Copy link
Member

@BODAPATIMAHESH - Thanks for the contribution. Can you please address Copilot's comments ?

@BODAPATIMAHESH
Copy link
Contributor Author

Thanks. I will work on the comments

@BODAPATIMAHESH
Copy link
Contributor Author

@BODAPATIMAHESH - Thanks for the contribution. Can you please address Copilot's comments ?

Thanks , I will resolve and update

@BODAPATIMAHESH
Copy link
Contributor Author

@hariharans29 I initially formatted the entire file using clang-format, but realized that most of the changes were unrelated to my patch. So, I updated the formatting to include only the changes relevant to my patch. I'm open to suggestions if there's a preferred approach.

@hariharans29
Copy link
Member

@hariharans29 I initially formatted the entire file using clang-format, but realized that most of the changes were unrelated to my patch. So, I updated the formatting to include only the changes relevant to my patch. I'm open to suggestions if there's a preferred approach.

Formating your changes is fine. Could you ensure going over Copilot's comments one by one and ensuring it is addressed ?

Also, does your change need unit tests or existing ones should do ?

@BODAPATIMAHESH
Copy link
Contributor Author

@hariharans29 I initially formatted the entire file using clang-format, but realized that most of the changes were unrelated to my patch. So, I updated the formatting to include only the changes relevant to my patch. I'm open to suggestions if there's a preferred approach.

Formating your changes is fine. Could you ensure going over Copilot's comments one by one and ensuring it is addressed ?

Also, does your change need unit tests or existing ones should do ?

Thanks.
No additional test cases are needed for this optimization; the existing tests with M=1 sufficiently validate the changes.

@BODAPATIMAHESH
Copy link
Contributor Author

@hariharans29 I've addressed the Copilot review comments. Please take a look at the latest changes.

@hariharans29
Copy link
Member

@hariharans29 I've addressed the Copilot review comments. Please take a look at the latest changes.

Can you please "resolve" them (i.e.) click the button for the Copilot comments ? I think that is a gating requirement for merging.

@hariharans29
Copy link
Member

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@BODAPATIMAHESH
Copy link
Contributor Author

@hariharans29 I've addressed the Copilot review comments. Please take a look at the latest changes.

Can you please "resolve" them (i.e.) click the button for the Copilot comments ? I think that is a gating requirement for merging.

@hariharans29 I hope all are fixed now.

@hariharans29
Copy link
Member

@hariharans29 I've addressed the Copilot review comments. Please take a look at the latest changes.

Can you please "resolve" them (i.e.) click the button for the Copilot comments ? I think that is a gating requirement for merging.

@hariharans29 I hope all are fixed now.

Thanks. I am not familir with Power ISA and I am trying to find another reviewer before merging. CC: @jywu-msft

@hariharans29
Copy link
Member

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@hariharans29
Copy link
Member

/azp run Linux QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hariharans29
Copy link
Member

Can you rebase with main ? I think you need this fix - #25877

Added a VSX-based implementation of MlasGemmQuantKernel optimized
for the case when M = 1.
Verified correctness using ONNX Runtime's built-in tests and
onnxruntime_mlas_tests;no regressions observed.
Evaluated performance using a Granite 8-bit quantized model and
observed approximately 3-5% improvement in token generation speed.
Fixing the indexation of qgemm_kernel_power10.cpp file.
Avoided const_cast and used a const-correct approach.
@BODAPATIMAHESH
Copy link
Contributor Author

Can you rebase with main ? I think you need this fix - #25877

Thanks @hariharans29 . I have rebased with main.

@hariharans29
Copy link
Member

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@hariharans29 hariharans29 merged commit b49e3b1 into microsoft:main Sep 3, 2025
88 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants