[1.23.0] Cherry-pick PR #25652 (properly remove in-memory references)#25691
Closed
adrianlizarraga wants to merge 1 commit intorel-1.23.0from
Closed
[1.23.0] Cherry-pick PR #25652 (properly remove in-memory references)#25691adrianlizarraga wants to merge 1 commit intorel-1.23.0from
adrianlizarraga wants to merge 1 commit intorel-1.23.0from
Conversation
<!-- Describe your changes. --> Make Node::ToProto() const call Graph::ToGraphProto() const so it does process all of the subgraphs recursively and removes all the in-memory references. <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Node::ToProto() const does not respect constness of subgraph attributes and calls non-const version of Graph::ToGraphProto() which does not process subgraph initializers and does not remove in-memory references.
Member
|
LGTM |
yuslepukhin
approved these changes
Aug 8, 2025
snnn
approved these changes
Aug 8, 2025
Contributor
Author
|
We have other PRs to cherry pick. Let's not merge this yet. Trying to do it in a batch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks #25652
There was a merge conflict with the changes to core/optimizer/qdq_transformer/where_dummy_dq.cc. That file was modified in PR 25652 but it does not exist in the rel-1.23.0 branch.
where_dummy_qq.ccwas added in #25576 (not in rel-1.23.0). Please review carefully.