GPG changed default install location on 12/31/2025 for Windows#26917
Merged
GPG changed default install location on 12/31/2025 for Windows#26917
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
tianleiwu
previously approved these changes
Jan 7, 2026
Contributor
tianleiwu
left a comment
tianleiwu
left a comment
There was a problem hiding this comment.
The PR addresses GPG signing issues in the Windows CI environment for Java artifacts. It improves the robustness of locating the gpg.exe binary and adds a cleanup step for the GPG trust database to prevent potential corruption or stale state issues.
Detailed Review
tools/ci_build/github/windows/sign_java_artifacts.py
1. GPG Path Detection (get_gpg_path)
- The update to search for
gpg.exein both%ProgramFiles(x86)%and%ProgramFiles%is a good addition. As noted in the comments, the tool installation location can vary (e.g., changed on 12/31/2025). This makes the script more resilient.
2. TrustDB Cleanup (clean_gpg_trustdb)
clean_gpg_trustdbexplicitly removestrustdb.gpgfrom theAPPDATAdirectory. This is a practical fix for CI environments where state persistence can lead to conflicts.- Note: The error handling (
try...except OSError) prints a warning but allows execution to continue, which is appropriate.
3. Main Execution Flow
- Calling
gpg --check-trustdbensures that the trust database is in a valid state before importing keys. - Adding
--yesto thegpg --importcommand ensures non-interactive execution.
Conclusion
The changes are well-targeted fixes for the Windows CI environment.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
tianleiwu
approved these changes
Jan 7, 2026
alex-spacemit
pushed a commit
to spacemit-com/onnxruntime
that referenced
this pull request
Jan 20, 2026
…soft#26917) ### Description Update search for GPG to check for both Program Files and Program Files (x86) ### Motivation and Context --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update search for GPG to check for both Program Files and Program Files (x86)
Motivation and Context