Conversation
…enceSession.h to correct the order of the destructor calls since session_state_ has a dependency on execution_providers_
snnn
approved these changes
Dec 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: switches back the order of the session_state_ and execution_providers_ member declarations in InferenceSession
Motivation and Context
execution_providers_ is being destroyed before session_state_, and in some winml test cases this causes work to be queued on an executioncontext after it had already been closed which results in an assertion failure. It seems like the order of declaration for these member variables were swapped in this PR (#2449). This causes the order that these members are constructed and destroyed to swap as well, violating the dependency that session_state_ has on execution_providers_.