Add PE version info to onnxruntime_providers_vitisai.dll#27626
Merged
adrianlizarraga merged 1 commit intomicrosoft:mainfrom Mar 13, 2026
Merged
Add PE version info to onnxruntime_providers_vitisai.dll#27626adrianlizarraga merged 1 commit intomicrosoft:mainfrom
adrianlizarraga merged 1 commit intomicrosoft:mainfrom
Conversation
Add a Windows VERSIONINFO resource (.rc file) for the Vitis AI provider DLL, following the same pattern used for CUDA, TensorRT, and QNN EPs (added in microsoft#24606). This embeds the ORT version into the DLL's PE header so it shows up in file properties. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Windows PE VERSIONINFO metadata to the VitisAI execution provider DLL so the ORT version is embedded in onnxruntime_providers_vitisai.dll and visible in Windows file properties, consistent with the pattern used for other provider DLLs.
Changes:
- Add a new
onnxruntime_providers_vitisai.rcdefiningVS_VERSION_INFOresource values for the VitisAI provider DLL. - Update the VitisAI provider CMake to compile the
.rcfile on Windows and defineFILE_NAMEfor the resource.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
onnxruntime/core/providers/vitisai/onnxruntime_providers_vitisai.rc |
Adds the Windows VERSIONINFO resource for the VitisAI provider DLL. |
cmake/onnxruntime_providers_vitisai.cmake |
Includes the .rc on WIN32 and defines FILE_NAME for resource compilation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Contributor
|
Hi @mingyueliuh and @zz002, can you please take a look when you have a chance? |
adrianlizarraga
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a Windows VERSIONINFO resource (.rc file) for the Vitis AI provider DLL, following the same pattern used for CUDA, TensorRT, and QNN EPs (added in #24606). This embeds the ORT version into the DLL's PE header so it shows up in file properties.
Motivation and Context
Need version in onnxruntime_providers_vitisai.dll to track changes.