Conversation
csharp/test/Microsoft.ML.OnnxRuntime.EndToEndTests/runtest-docker-gpu.sh
Outdated
Show resolved
Hide resolved
What kind of vars this script sets and what does it download? Should we rename this script? Perhaps some comments in the header? Refers to: tools/ci_build/github/azure-pipelines/nuget/templates/linux-set-variables-and-download.yml:3 in 79c19b8. [](commit_id = 79c19b8, deletion_comment = False) |
tools/ci_build/github/azure-pipelines/nuget/templates/test_win.yml
Outdated
Show resolved
Hide resolved
|
Would be nice to describe changes here on a high level. Fix Nuget pipeline is too general What specifically needs to be fixed. |
onnxruntime/test/onnx/main.cc
Outdated
| logging_level = ORT_LOGGING_LEVEL_WARNING; | ||
| } else if (verbosity_option_count > 1) { | ||
| logging_level = ORT_LOGGING_LEVEL_VERBOSE; | ||
| logging_level = ORT_LOGGING_LEVEL_INFO; |
There was a problem hiding this comment.
how about something like this for more flexibility:
logging_level = ORT_LOGGING_LEVEL_ERROR - std::min(verbosity_option_count, ORT_LOGGING_LEVEL_ERROR)
also i think verbosity_option_count can be unsigned
There was a problem hiding this comment.
looks good. i think we can still make verbosity_option_count unsigned to ensure it won't be negative, but it currently looks like it shouldn't be
| @@ -10,27 +10,30 @@ | |||
|
|
|||
| import argparse | |||
There was a problem hiding this comment.
looks like this is called from Linux now, maybe tools/ci_build/github/windows is not the best location. can address it in a separate PR
|
It's known that the nuget GPU pipeline will continue to fail. I feel sorry for that, I would like to let this change go first and put the fix in another PR if nobody disagree. |
Description:
Motivation and Context
Currently,
The nuget CPU pipeline fails with error of:
"curl: command not found"
while downloading azcopy which is for downloading the test data. But because I've put azcopy and all the test on the machines, so there is no need to re-download them from Azure again. To fix the problem, instead of installing curl on the machines, I deleted the data downloading step. If later on we need to add the step back, please only bring the "Download test data" step back, not the "Download azcopy". Because the azcopy command is already available at "/usr/bin/".
The code coverage pipeline fails because it uses latest protobuf release and our code isn't compatible with that. I've sent the issue to Pranav. Before we get a fix, I want to migrate the pipeline to Linux and LLVM. The LLVM code coverage tool has better documentation and it is easier to configure. It can merge the coverage result from multiple runs without extra tools.