Hardcode WinML umbrella lib to windowsapp.lib, fix building of NodeJS bindings#4133
Merged
tiagoshibata merged 1 commit intomasterfrom Jun 8, 2020
Merged
Conversation
ryanlai2
previously approved these changes
Jun 4, 2020
smk2007
reviewed
Jun 5, 2020
| target_link_libraries(winml_dll PRIVATE winml_lib_telemetry) | ||
|
|
||
| target_link_libraries(winml_dll PRIVATE RuntimeObject.lib) | ||
| target_link_libraries(winml_dll PRIVATE windowsapp.lib) |
Member
There was a problem hiding this comment.
Can you add a comment here explaining why this needs to be linked here?
tiagoshibata
changed the title
snnn
previously approved these changes
Jun 5, 2020
snnn
reviewed
Jun 5, 2020
nodejs/script/build.ts
Outdated
| (REBUILD ? 'reconfigure' : 'configure'), | ||
| '--arch=x64', | ||
| '--CDnapi_build_version=3', | ||
| '--CDnapi_build_version=6', |
Contributor
Author
There was a problem hiding this comment.
You're welcome :)
Contributor
There was a problem hiding this comment.
The build issue is figured out in #4148 . by upgrading node_addon_api to v3.0.0 we are able to compile in all Node.js version using NAPI v3.
Contributor
|
Please feel safe to ignore the test failure in "Windows-CPU-CI", which is a test job scheduled by me. |
Contributor
Author
|
Should I re-run the other failed pipelines? |
Contributor
I'll do it on behalf of you. |
fs-eire
requested changes
Jun 6, 2020
Contributor
fs-eire
left a comment
fs-eire
left a comment
There was a problem hiding this comment.
Please revert back to using NAPI v3
tiagoshibata
force-pushed
the
user/ticastro/hardcode-winml-umbrella
branch
from
417e3bc to
c8ad161
Compare
fs-eire
approved these changes
Jun 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Use windowsapp.lib umbrella lib. This is a no-op when building WinML w/ CMAKE_SYSTEM_NAME == WindowsStore, but is required to work around some linking bugs in internal builds. We'll get it removed after some more review and discussion.