You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some session option values (default or user provided) may not work with some EPs. Rather than put the onus on the user to know these, make the appropriate choice for the session option while logging the change.
If the issue is with user provided options, it is fair to throw, but in cases where the default session option value (not user provided) does not work with some EPs, it doesn't seem fair to throw and have the user change it to the non-default working value. So picking the approach of changing the faulty session option value - default or user provided.
Removed the duplicate handling logic in the C API layer (was superfluous to begin with given that eventually RegisterExecutionProvider() did the exact same thing and there is a call to RegisterExecutionProvider()). With this all handling is done in a centralized place and keeps all APIs consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Motivation and Context
Takeaway from #4630