Skip to content

Prevent saving a model containing fused nodes backed by a compiled kernel#5840

Merged
skottmckay merged 1 commit intomasterfrom
skottmckay/DisallowSavingModelWithCompiledOps
Nov 18, 2020
Merged

Prevent saving a model containing fused nodes backed by a compiled kernel#5840
skottmckay merged 1 commit intomasterfrom
skottmckay/DisallowSavingModelWithCompiledOps

Conversation

@skottmckay
Copy link
Contributor

Description:
Prevent saving a model containing fused nodes backed by a compiled kernel. We don't have a way to save the compiled kernels so the saved model will be invalid and fail to load.

Motivation and Context
Github issue #3802 where optimized model with TensorRT kernels was saved and couldn't be loaded.
Also addresses PR comment from the change to support compiling EPs in an ORT format model.

…y to save the compiled kernels so the saved model will be invalid.
@skottmckay skottmckay requested a review from a team as a code owner November 18, 2020 02:43
Copy link
Contributor

@guoyu-wang guoyu-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@skottmckay skottmckay merged commit b3a6ed1 into master Nov 18, 2020
@skottmckay skottmckay deleted the skottmckay/DisallowSavingModelWithCompiledOps branch November 18, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants