Add robust dependency check for Python package#6436
Add robust dependency check for Python package#6436jywu-msft merged 15 commits intomicrosoft:masterfrom
Conversation
|
/azp run orttraining-distributed |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@snnn, @jywu-msft This should solve the only remaining test failure (in Windows GPU CI Pipeline). |
I can do it. But now I'm busily working on Security Development Lifecycle (SDL) items. I won't have extra time to work on this in this week or the next week. |
|
@jywu-msft, could you please take a look at this PR? |
thanks. Will take a look. was OOF so still catching up on things. |
|
Merged the latest master to pick up the recent fix for Windows build (caused by update to numpy 1.20). |
|
/azp run Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Windows CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline |
|
/azp run Windows GPU CI Pipeline, WIndows GPU TensorRT CI Pipeline, centos7_cpu, centos7_cpu (linux_centos_ci Debug), centos7_cpu (linux_centos_ci Release), orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
|
Azure Pipelines successfully started running 9 pipeline(s). |
|
/azp run orttraining-distributed, Linux Nuphar CI Pipeline |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jywu-msft
left a comment
There was a problem hiding this comment.
please test the code as I documented. it doesn't work.
"Windows GPU CI Pipeline" completed successfully. Do you believe something is missing in the pipeline? |
That pipeline is using python 3.7. |
|
/azp run Windows GPU CI Pipeline |
|
Commenter does not have sufficient privileges for PR 6436 in repo microsoft/onnxruntime |
yes, the fix must be tested with python 3.8 |
|
So, all the builds passed. |
Python packaging pipeline succeeded for all supported operating systems and Python versions. |
|
@jywu-msft, @snnn, |
sorry for the delay. things have been busy as of late. |
|
/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux CPU Minimal Build E2E CI Pipeline,Linux Nuphar CI Pipeline,MacOS NoContribops CI Pipeline,Linux OpenVINO CI Pipeline,orttraining-distributed |
|
Azure Pipelines successfully started running 9 pipeline(s). |
|
/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline |
|
Azure Pipelines successfully started running 9 pipeline(s). |
|
/azp run orttraining-amd-gpu-ci-pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description:
os.add_dll_directory) is used to specify DLL search location.import torchis placed beforeimport onnxruntime, but an error occurs if the order of these imports is switched (onnxruntime could end up using CUDA DLLs distributed with PyTorch).Motivation and Context:
import onnxruntimecomplains about not being able to find a DLL - it's not obvious which dependency is missing.Affected components:
fixes #5697
fixes #5963
fixes #6433
fixes #6435