Revert Gather Grad optimization in PR 6381 targeted for Rocm#6880
Merged
Revert Gather Grad optimization in PR 6381 targeted for Rocm#6880
Conversation
weixingzhang
reviewed
Mar 3, 2021
weixingzhang
approved these changes
Mar 3, 2021
weixingzhang
pushed a commit
that referenced
this pull request
Aug 6, 2021
* revert gather_grad_impl.cu * put stream changes back in * restrict changes to commenting launch of optimized version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reasons not fully understood, PR 6381 has increased the variance of the observed loss on our BERT convergence test. As it is only an optimization, we will revert for now and revisit the situation in the future.
Final loss is calculated across 10 runs of run_convergence_test.py.