Add fp16 support for BatchNormalization Forward/Backward#7218
Closed
Add fp16 support for BatchNormalization Forward/Backward#7218
Conversation
Contributor
|
Note that as I mentioned in #6946 the cuda kernel for BatchNorm breaks the ONNX spec in outputtting inverse standard deviation instead of variance for the saved statistic. While doing so avoids the need for an extra operation here since we can use the cudnn output directly, I'm not sure if it's worth breaking spec for that (and that too it's probably not a significant performance gain). But then again the spec for batchnorm was recently updated to drop the redundant "saved mean/var" output (onnx/onnx#3379), so I think those two outputs can just be removed entirely (at least for opset 14). |
Contributor
|
Hi @mindest, which model need this op? is this urgently needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
meanandvarwith outputsmeanandvar, respectivelyMotivation and Context
running_meanandrunning_vardo not change in training mode