Conversation
fdwr
approved these changes
Dec 3, 2018
RyanUnderhill
approved these changes
Dec 4, 2018
Contributor
RyanUnderhill
left a comment
RyanUnderhill
left a comment
There was a problem hiding this comment.
Approving the same changes made in internal review.
TedThemistokleous
added a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
Nov 12, 2024
…trib ops (microsoft#76) Co-authored-by: Ted Themistokleous <tedthemistokleous@amd.com>
quic-ankus
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Nov 25, 2025
[AISW-137623] MaxPool input rank-3 auto pad bug fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously both were doing two broadcast loops when they didn't need to since zero_point and scale get broadcast in the same manner. Also the code is simplified to not rely on the eigen templates unnecessarily.