Minor changes to support inclusion of x86 bits in the Nuget packaging pipeline#916
Merged
hariharans29 merged 19 commits intomasterfrom Apr 27, 2019
Merged
Minor changes to support inclusion of x86 bits in the Nuget packaging pipeline#916hariharans29 merged 19 commits intomasterfrom
hariharans29 merged 19 commits intomasterfrom
Conversation
jignparm
previously approved these changes
Apr 26, 2019
| <ProjectReference Include="$(OnnxRuntimeCSharpRoot)\src\Microsoft.ML.OnnxRuntime\Microsoft.ML.OnnxRuntime.csproj" /> | ||
| <PackageReference Include="CommandLineParser" Version="2.4.3" /> | ||
| <PackageReference Include="Microsoft.ML.Scoring" Version="1.1.0" /> | ||
| <PackageReference Include="Microsoft.ML.OnnxRuntime" Version="0.3.1" /> |
Contributor
There was a problem hiding this comment.
The perftool project needs to be updated in general (i.e. read from protobuf input data files).
@hariharans29 -since we have a reference to the csproj (below), we should be able to drop this package reference now.
Include="$(OnnxRuntimeCSharpRoot)\src\Microsoft.ML.OnnxRuntime\Microsoft.ML.OnnxRuntime.csproj" />
Member
Author
There was a problem hiding this comment.
Oh that's right. So let me just drop this line in the csproj. Thanks.
jignparm
approved these changes
Apr 26, 2019
pranavsharma
approved these changes
Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.