Skip to content

Unregister aten_linear#1821

Merged
justinchuby merged 2 commits intomicrosoft:mainfrom
titaiwangms:titaiwang/unregister_aten_linear
Aug 20, 2024
Merged

Unregister aten_linear#1821
justinchuby merged 2 commits intomicrosoft:mainfrom
titaiwangms:titaiwang/unregister_aten_linear

Conversation

@titaiwangms
Copy link
Contributor

Fix #1819

Instead, we rely on PyTorch decomposition to use aten::addmm (Gemm) for accuracy.

@titaiwangms titaiwangms added the module: torchlib Related to the torch/aten function lib in development label Aug 20, 2024
@titaiwangms titaiwangms enabled auto-merge (squash) August 20, 2024 01:16
@codecov
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.85%. Comparing base (f5709f0) to head (a4ee8a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1821      +/-   ##
==========================================
- Coverage   74.88%   74.85%   -0.03%     
==========================================
  Files         248      248              
  Lines       26640    26638       -2     
  Branches     4897     4895       -2     
==========================================
- Hits        19949    19940       -9     
- Misses       5750     5757       +7     
  Partials      941      941              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titaiwangms titaiwangms disabled auto-merge August 20, 2024 02:06
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@justinchuby justinchuby merged commit ce7711e into microsoft:main Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: torchlib Related to the torch/aten function lib in development

Projects

Development

Successfully merging this pull request may close these issues.

[torchlib] Remove aten.linear

2 participants