Skip to content

[IR] Remove mkdirs call in external tensor save #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinchuby merged 3 commits into from
Jan 23, 2025
Merged

[IR] Remove mkdirs call in external tensor save #2033

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47bd05e
[IR] handle with external data path is empty or in the same dir as model
justinchuby Jan 23, 2025
14f2287
Remove call
justinchuby Jan 23, 2025
fa8f9d1
Merge branch 'main' into justinchu/fix-external
justinchuby Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions onnxscript/ir/external_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,6 @@ def convert_tensors_to_external(
should match the input tensor order.
"""
path = os.path.join(base_dir, relative_path)
# Check if file path is valid, and create subsequent subdirectories within the path if they don't exist
os.makedirs(os.path.dirname(path), exist_ok=True)

# Check if output path exists. Load pre-existing external data if it does.
if os.path.exists(path):
Expand Down
Loading