Skip to content

Conversation

@titaiwangms
Copy link
Contributor

op.Dropout is only enabled when dropout_p is not 0, and added a reference issue discussion about why op.Where and op.IsNaN are needed when attention mask is boolean value.

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.06%. Comparing base (e2fe5e7) to head (a43a1e1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
onnxscript/function_libs/torch_lib/ops/nn.py 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2482      +/-   ##
==========================================
- Coverage   70.09%   70.06%   -0.03%     
==========================================
  Files         211      211              
  Lines       25600    25603       +3     
  Branches     2568     2571       +3     
==========================================
- Hits        17944    17940       -4     
- Misses       6771     6776       +5     
- Partials      885      887       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby enabled auto-merge (squash) August 8, 2025 18:03
@justinchuby justinchuby merged commit b042f5b into microsoft:main Aug 8, 2025
26 of 32 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: torchlib Related to the torch/aten function lib in development

Projects

Development

Successfully merging this pull request may close these issues.

2 participants