Skip to content

Conversation

@titaiwangms
Copy link
Contributor

Split input (SymbolicTensor) could have no const_value, but with shape that gives us information of how many outputs an op.Split should return.

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.99%. Comparing base (1934901) to head (cb7a367).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
onnxscript/optimizer/_constant_folding.py 71.42% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2544   +/-   ##
=======================================
  Coverage   69.99%   69.99%           
=======================================
  Files         216      216           
  Lines       26074    26097   +23     
  Branches     2618     2619    +1     
=======================================
+ Hits        18250    18267   +17     
- Misses       6921     6925    +4     
- Partials      903      905    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titaiwangms titaiwangms linked an issue Sep 4, 2025 that may be closed by this pull request
@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board Sep 5, 2025
@titaiwangms titaiwangms merged commit e76bfe0 into microsoft:main Sep 5, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

SplitToSequnce const folding only works for static shapes

2 participants