Skip to content

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Oct 10, 2025

Deprecate Rank and IsScalar and remove all usages. Do not remove the definitions because older versions of PyTorch assumes their existance.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added module: torchlib Related to the torch/aten function lib in development merge at lgtm Reviewers can merge when they approve labels Oct 10, 2025
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.39%. Comparing base (59c3d32) to head (3334eda).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2624      +/-   ##
==========================================
+ Coverage   70.30%   70.39%   +0.08%     
==========================================
  Files         222      222              
  Lines       26276    26275       -1     
  Branches     2624     2629       +5     
==========================================
+ Hits        18474    18496      +22     
+ Misses       6885     6859      -26     
- Partials      917      920       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added this to the 0.5.4 milestone Oct 10, 2025
@justinchuby justinchuby removed the merge at lgtm Reviewers can merge when they approve label Oct 10, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added the merge at lgtm Reviewers can merge when they approve label Oct 10, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby enabled auto-merge (squash) October 13, 2025 02:30
@justinchuby justinchuby merged commit 32a61f4 into main Oct 13, 2025
32 checks passed
@justinchuby justinchuby deleted the justinchu/deprecate-rank branch October 13, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge at lgtm Reviewers can merge when they approve module: torchlib Related to the torch/aten function lib in development

Projects

Development

Successfully merging this pull request may close these issues.

3 participants