Skip to content

Conversation

@ruro
Copy link
Contributor

@ruro ruro commented Nov 10, 2025

See pytorch/pytorch#167063.

The tests in this PR rely on pytorch/pytorch#167465.

@ruro
Copy link
Contributor Author

ruro commented Nov 10, 2025

@microsoft-github-policy-service agree

@ruro ruro force-pushed the onnx_dynamo_export_fake_quantize branch 2 times, most recently from 82f3844 to 9288439 Compare November 10, 2025 14:26
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.10%. Comparing base (c1bfdfc) to head (ae22c2f).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 89.13% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2696      +/-   ##
==========================================
+ Coverage   70.04%   70.10%   +0.05%     
==========================================
  Files         226      226              
  Lines       27177    27221      +44     
  Branches     2734     2747      +13     
==========================================
+ Hits        19036    19083      +47     
+ Misses       7197     7192       -5     
- Partials      944      946       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruro ruro force-pushed the onnx_dynamo_export_fake_quantize branch 2 times, most recently from 160320e to 92d0b73 Compare November 14, 2025 19:12
@ruro
Copy link
Contributor Author

ruro commented Nov 14, 2025

I originally wanted to add the OpInfos required for testing the fake_quantize_per_*_affine ops upstream, but now I see that you have tests/function_libs/torch_lib/extra_opinfo.py. So I'm going to probably drop the corresponding pytorch PR. Oops! 😅

I think this PR should be mostly ready now, unless I missed something.

@ruro ruro marked this pull request as ready for review November 14, 2025 19:23
@ruro ruro force-pushed the onnx_dynamo_export_fake_quantize branch from 92d0b73 to ae22c2f Compare November 14, 2025 23:31
@titaiwangms titaiwangms merged commit 6247ac1 into microsoft:main Nov 18, 2025
32 checks passed
@titaiwangms
Copy link
Contributor

Thanks!

@titaiwangms titaiwangms added the module: torchlib Related to the torch/aten function lib in development label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: torchlib Related to the torch/aten function lib in development

Projects

Development

Successfully merging this pull request may close these issues.

2 participants