Use IR and inplace output in relace_functions #2703
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2703 +/- ##
=======================================
Coverage 70.04% 70.05%
=======================================
Files 226 226
Lines 27177 27173 -4
Branches 2734 2734
=======================================
- Hits 19036 19035 -1
+ Misses 7197 7194 -3
Partials 944 944 ☔ View full report in Codecov by Sentry. |
gramalingam
reviewed
Nov 12, 2025
| def replace_functions( | ||
| model: onnx.ModelProto, functions: Sequence[onnx.FunctionProto] | ||
| ) -> onnx.ModelProto: | ||
| def replace_functions(irmodel: ir.Model, irfunctions: Sequence[ir.Function]) -> None: |
Collaborator
There was a problem hiding this comment.
I would suggest two functions: create a new one replace_functions_inplace, which is like this one (with IR inputs updated in-place), and update the existing replace_functions to call the inplace one in the middle ... some might need one or the other
Collaborator
|
See #2708 |
titaiwangms
pushed a commit
that referenced
this pull request
Nov 18, 2025
Redo #2703, thanks to Titai. Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use IR and inplace