Add OPENHCL_CONFIDENTIAL_DEBUG to manifest#1627
Merged
stunes-ms merged 1 commit intoJun 30, 2025
Merged
Conversation
benhillis
approved these changes
Jun 30, 2025
This was referenced Jul 1, 2025
stunes-ms
added a commit
that referenced
this pull request
Jul 2, 2025
Release backport of PR #1501 and PR #1627. If the debug bit is set in the VM's TDX attributes, the host can be trusted. This change gets the TD report in the boot shim and checks the debug bit. If it's set, parse the dynamic command line to allow enabling, e.g., confidential debugging. Note that microsoft/OHCL-Linux-Kernel#79 will need to be resolved before hardware debug can be disabled in the manifest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1501 modified igvmfilegen to no longer explicitly add OPENHCL_CONFIDENTIAL_DEBUG to the static command line if debug is enabled. This broke SNP: SNP cannot yet directly read the debug bit, and the vmbus relay depends on trusting the host for now. This change adds OPENHCL_CONFIDENTIAL_DEBUG to the static command line explicitly in the meantime (except for TDX, because it can directly read the debug bit).