Saving flamegraphview in speedscope-format does not work

[Thomas-S-B]

Exception is thrown when i want to save a flamegraphview in the speedscope-format:

System.InvalidOperationException: Sample with no Thread assigned!

  bei Microsoft.Diagnostics.Tracing.Stacks.Formats.SpeedScopeStackSourceWriter.<>c__DisplayClass2_0.<GetSortedSamplesPerThread>b__0(StackSourceSample sample)

  bei Diagnostics.Tracing.StackSources.FilterStackSource.<>c__DisplayClass1_0.<ForEach>b__0(StackSourceSample sample)

  bei Microsoft.Diagnostics.Tracing.Stacks.MutableTraceEventStackSource.ForEach(Action`1 callback)

  bei Diagnostics.Tracing.StackSources.FilterStackSource.ForEach(Action`1 callback)

  bei Microsoft.Diagnostics.Tracing.Stacks.Formats.SpeedScopeStackSourceWriter.GetSortedSamplesPerThread(StackSource stackSource)

  bei Microsoft.Diagnostics.Tracing.Stacks.Formats.SpeedScopeStackSourceWriter.Export(StackSource source, TextWriter writer, String name)

  bei Microsoft.Diagnostics.Tracing.Stacks.Formats.SpeedScopeStackSourceWriter.WriteStackViewAsJson(StackSource source, String filePath)

  bei PerfView.StackWindow.DoSave(Object sender, RoutedEventArgs e)

  bei PerfView.StackWindow.DoSaveAs(Object sender, RoutedEventArgs e)

  bei System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)

  bei System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)

  bei System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)

  bei System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)

  bei System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)

  bei System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)

  bei System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)

  bei System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)

  bei System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)

  bei System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)

  bei System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)

  bei System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)

  bei System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)

  bei System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)

  bei System.Windows.Input.CommandManager.TransferEvent(IInputElement newSource, ExecutedRoutedEventArgs e)

  bei System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)

  bei System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)

  bei System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)

  bei System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)

  bei System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)

  bei System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)

  bei System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)

  bei System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)

  bei System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)

  bei System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)

  bei MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)

  bei System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)

  bei System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)

  bei System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

[adamsitnik]

Hi @Thomas-S-B

Is there any chance that you could share the trace file?

[Thomas-S-B]

Hi @adamsitnik,

i'm really sorry, but due NDA it's not possible.

[adamsitnik]

Hi @Thomas-S-B

With the most recent changes, you should not be getting this error anymore.

Could you please use latest PerfView from https://github.com/microsoft/perfview/releases/tag/P2.0.50 and give it a try?

[Thomas-S-B]

Hello @adamsitnik,

it works like a charm – thank you very much.
Adam: Great work!

Cheers
Thomas

[adamsitnik]

@Thomas-S-B thank you!

btw you might want to give a try to chromium trace file format which we have added recently: #1113

[Thomas-S-B]

Ok i will try it perhaps tomorrow.
Once again: Great work, i like Perfview very much and use it really often.