Fix tab navigation to hyperlinks inside help ribbons #2201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the last round of accessibility bug fixes, only one bug was sent back as unresolved, so this should fix that last accessibility bug. Essentially, the hyperlinks inside the help ribbons were not navigable by the keyboard using tab navigation. It seems that this is a bug with RichTextBox or FlowDocument as I was not able to get it to work, so I just converted it to a TextBlock and added a border to match the previous styling.
Comparing the help ribbons before and after the change, the styling is identical.