[SymbolReader] Make symbol server timeout configurable and remove dead server mechanism #2209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [SymbolReader] Make symbol server timeout configurable
[SymbolReader] Make symbol server timeout configurable and remove dead server mechanism
May 23, 2025
brianrob
reviewed
May 23, 2025
| /// <summary> | ||
| /// Gets or sets the timeout in seconds for symbol server requests. Default is 60 seconds. | ||
| /// </summary> | ||
| public int ServerTimeoutSeconds { get; set; } = 60; |
Member
There was a problem hiding this comment.
Please change this to public TimeSpan ServerTimeout.
Contributor
Author
There was a problem hiding this comment.
Changed the property from int ServerTimeoutSeconds to TimeSpan ServerTimeout and updated all usages in the code. Commit c7f656e.
Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Member
|
Copilot Post-Mortem:
|
brianrob
requested review from
cincuranet,
leculver,
marklio and
mconnew
as code owners
leculver
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
This PR addresses two issues with symbol server resolution in PerfView:
Makes the symbol server timeout configurable by adding a new
ServerTimeoutproperty to theSymbolReaderclass with a default value of 60 seconds (matching the previous hard-coded behavior).Removes the "mark as dead" functionality for servers, which means that subsequent requests will still go through after a timeout, rather than blocking a server for 5 minutes after a failure.
These changes will significantly improve PerfView's behavior in slower network environments by:
Implementation Details
ServerTimeoutproperty to control the timeout behaviorFixes #1895.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
crl3.digicert.comdotnet build /p:Configuration=Release(dns block)dotnet build src/TraceEvent/TraceEvent.csproj /p:Configuration=Release(dns block)crl4.digicert.comdotnet build /p:Configuration=Release(dns block)dotnet build src/TraceEvent/TraceEvent.csproj /p:Configuration=Release(dns block)ocsp.digicert.comdotnet build /p:Configuration=Release(dns block)dotnet build src/TraceEvent/TraceEvent.csproj /p:Configuration=Release(dns block)s.symcb.comdotnet build /p:Configuration=Release(dns block)dotnet build src/TraceEvent/TraceEvent.csproj /p:Configuration=Release(dns block)s.symcd.comdotnet build /p:Configuration=Release(dns block)dotnet build src/TraceEvent/TraceEvent.csproj /p:Configuration=Release(dns block)ts-crl.ws.symantec.comdotnet build /p:Configuration=Release(dns block)dotnet build src/TraceEvent/TraceEvent.csproj /p:Configuration=Release(dns block)ts-ocsp.ws.symantec.comdotnet build /p:Configuration=Release(dns block)dotnet build src/TraceEvent/TraceEvent.csproj /p:Configuration=Release(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.