Fix parsing issues and add support for additional events to the Linux perf text file parser #2286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle some parsing edge cases and add support for disk IO events
Fix issues with previous change
Add support for sched:sched_wakeup event
Add perfview event processing for process_exec
Fix style issue
Add test for sched:exec_process
Add support for IRQ events
thooot
requested review from
brianrob,
cincuranet,
leculver,
marklio and
mconnew
as code owners
brianrob
reviewed
Aug 21, 2025
| exit = ReadExit(source); | ||
| source.SkipUpTo('\n'); | ||
| ScheduleSwitch schedSwitch = ReadScheduleSwitch(source); | ||
| IEnumerable<Frame> frames = ReadFramesForSample(processCommand, pid, tid, threadTimeFrame, source); |
Member
There was a problem hiding this comment.
No need to change in this PR - I think we should consider if there is a nice pattern we can employ here to ensure that the call to read the stack happens automatically for all event types.
brianrob
approved these changes
Aug 21, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves parsing support for more complex perf traces including ones where:
It also adds support for the following event types: