Only Dispose Non-Null Handles in ETWTraceEventSource #2291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianrob
requested review from
cincuranet,
leculver,
marklio and
mconnew
as code owners
mconnew
reviewed
Aug 29, 2025
| foreach (TraceEventNativeMethods.SafeTraceHandle handle in handles) | ||
| { | ||
| handle.Dispose(); | ||
| handle?.Dispose(); |
Member
There was a problem hiding this comment.
Should you also check if the handle is valid? Is this a standard SafeHandle? If so, calling Dispose on an invalid handle can throw.
Member
Author
There was a problem hiding this comment.
Yes, that's a good idea. Updated.
mconnew
approved these changes
Aug 29, 2025
This was referenced Oct 13, 2025
Closed
This was referenced Oct 22, 2025
Merged
This was referenced Oct 31, 2025
This was referenced Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an ETL file is malformed, it's possible to end up with a null handle in
ETWTraceEventSource.handles. Ensure that we only dispose of non-null handles.