Skip to content

fix: event info for waitForLoadState #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avodovnik merged 1 commit into from
Aug 13, 2021
Merged

fix: event info for waitForLoadState #1675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Playwright/Core/Frame.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,9 +525,9 @@ private Task WaitForURLAsync(string urlString, Regex urlRegex, Func<string, bool
};
}

private Waiter SetupNavigationWaiter(string apiName, float? timeout)
private Waiter SetupNavigationWaiter(string @event, float? timeout)
{
var waiter = new Waiter(_channel, apiName);
var waiter = new Waiter(_channel, @event);
waiter.RejectOnEvent<IPage>(Page, PageEvent.Close.Name, new("Navigation failed because page was closed!"));
waiter.RejectOnEvent<IPage>(Page, PageEvent.Crash.Name, new("Navigation failed because page was crashed!"));
waiter.RejectOnEvent<IFrame>(
Expand Down
4 changes: 2 additions & 2 deletions src/Playwright/Core/Waiter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ internal class Waiter : IDisposable
private bool _disposed;
private string _error;

internal Waiter(ChannelBase channel, string apiName)
internal Waiter(ChannelBase channel, string @event)
{
_channel = channel;
var beforeArgs = new { info = new { apiName = apiName, waitId = _waitId, phase = "before" } };
var beforeArgs = new { info = new { @event = @event, waitId = _waitId, phase = "before" } };
var connection = _channel.Connection;

_ = connection.SendMessageToServerAsync(channel.Guid, "waitForEventInfo", beforeArgs);
Expand Down