chore: roll Playwright to 1.18.0-beta-1642018269000#1934
Merged
mxschmitt merged 2 commits intoJan 16, 2022
Conversation
mxschmitt
force-pushed
the
roll/1.18.0-beta-1642018269000
branch
from
fb63f1f to
ecd7b63
Compare
Member
pavelfeldman
left a comment
pavelfeldman
left a comment
There was a problem hiding this comment.
Looks good. Are we missing Locator / FrameLocator tests? Also would be nice to double check our tracing test coverage is good - you change it a lot.
pavelfeldman
approved these changes
Jan 14, 2022
mxschmitt
force-pushed
the
roll/1.18.0-beta-1642018269000
branch
4 times, most recently
from
44e3126 to
938a6df
Compare
mxschmitt
force-pushed
the
roll/1.18.0-beta-1642018269000
branch
from
938a6df to
5af5678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1754
Fixes #1918
I'll follow-up with the last missing backport for rewriting the route handling matching logic: microsoft/playwright@c21d6b7#diff-d7c041137e763edae5c4d18bc8ded9a1ac668078e310712341c444ef3aac423b