chore: roll to 1.23#2184
Merged
Merged
Conversation
mxschmitt
commented
Jun 27, 2022
mxschmitt
commented
Jun 27, 2022
mxschmitt
commented
Jun 27, 2022
mxschmitt
commented
Jun 27, 2022
mxschmitt
commented
Jun 27, 2022
| } | ||
|
|
||
| [PlaywrightTest("page-network-response.spec.ts", "should report if request was fromServiceWorker")] | ||
| public async Task ShouldReportIfRequestWasFromServiceWorker() |
Contributor
Author
There was a problem hiding this comment.
mxschmitt
commented
Jun 27, 2022
| Response = response, | ||
| Status = 201, | ||
| Body = "", | ||
| Headers = new Dictionary<string, string> { |
Contributor
Author
There was a problem hiding this comment.
this fixes tests, was also made upstream the same way.
Class got renamed to align it with file name which is common in c# and we do it everywhere else.
mxschmitt
commented
Jun 27, 2022
| forcedColors: options.ForcedColors).ConfigureAwait(false)).Object; | ||
|
|
||
| context.Options = options; | ||
| ((Tracing)context.Tracing).LocalUtils = LocalUtils; |
Contributor
Author
There was a problem hiding this comment.
mxschmitt
commented
Jun 27, 2022
| case "crash": | ||
| Crashed?.Invoke(this, EventArgs.Empty); | ||
| break; | ||
| case "domcontentloaded": |
Contributor
Author
There was a problem hiding this comment.
aslushnikov
approved these changes
Jun 27, 2022
| }); | ||
| var page = await context.NewPageAsync(); | ||
| await page.GotoAsync(Server.Prefix + "/serviceworkers/empty/sw.html"); | ||
| var registrationResult = await page.EvaluateAsync<object>("() => window['registrationPromise']"); |
Contributor
There was a problem hiding this comment.
let's make sure that service worker was actually blocked, like we do upstream.
| [PlaywrightTest("browsercontext-service-worker-policy.spec.ts", "blocks service worker registration")] | ||
| public async Task ShouldBlockServiceWorkerRegistration() | ||
| { | ||
| var context = await Browser.NewContextAsync(new() |
Contributor
There was a problem hiding this comment.
don't forget to close the context!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.