Skip to content

fix: build with --output without trailing slash#2829

Merged
yury-s merged 2 commits into
mainfrom
fix-outputdir
Jan 17, 2024
Merged

fix: build with --output without trailing slash#2829
yury-s merged 2 commits into
mainfrom
fix-outputdir

Conversation

@mxschmitt
Copy link
Copy Markdown
Contributor

@mxschmitt mxschmitt commented Jan 17, 2024

Fixes #2827

My first attempt was using OutDir but it broke some of the LocalNugetTests. Instead we now call EnsureTrailingSlash.

Comment thread src/Playwright/build/Microsoft.Playwright.targets Outdated
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
@campersau
Copy link
Copy Markdown
Contributor

FYI: you used OutputDir instead of OutDir in your first commit: faf6ea0

@mxschmitt
Copy link
Copy Markdown
Contributor Author

mxschmitt commented Jan 17, 2024

Great discovery! No strong feelings, both will probably work (OutDir vs. OutputPath). PublishDir includes a trailing slash already, but wrapping it does probably not hurt either.

@campersau
Copy link
Copy Markdown
Contributor

In my testing PublishDir did not contain a trailing slash when a custom --output path was given which didn't include it #2827 (comment) . So I don't think that the MS documentation is correct in this case.
Either way it does not hurt to just always call EnsureTrailingSlash.

@yury-s yury-s merged commit 81279f1 into main Jan 17, 2024
@yury-s yury-s deleted the fix-outputdir branch January 17, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] MSB3073 error with Microsoft.Playwright 1.41.0 on Ubuntu

3 participants