fix: rewrite json channel converters#2831
Merged
Merged
Conversation
dgozman
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke in f947487. One way of fixing it is to update our
System.Text.Jsondependency to7.0.0or higher, since dotnet/runtime#46522 is fixed there, but we tried this in the past and we reverted in #2720.This solution of the PR works around the bug dotnet/runtime#46522 by going the ConverterFactory route.
Drive-by: Remove ChannelToGuidConverter, since we only have channel owner nowadays, no separate channels.
Fixes #2830