Skip to content

Update Playwright.csproj to upgrade Microsoft.Bcl.AsyncInterfaces#3010

Closed
RaminJolfaei wants to merge 1 commit into
microsoft:mainfrom
RaminJolfaei:patch-1
Closed

Update Playwright.csproj to upgrade Microsoft.Bcl.AsyncInterfaces#3010
RaminJolfaei wants to merge 1 commit into
microsoft:mainfrom
RaminJolfaei:patch-1

Conversation

@RaminJolfaei
Copy link
Copy Markdown

@RaminJolfaei RaminJolfaei commented Sep 27, 2024

upgrade Microsoft.Bcl.AsyncInterfaces to latest version 8.0.0

@RaminJolfaei RaminJolfaei changed the title Update Playwright.csproj to upgrade Microsoft.Bcl.AsyncInterfaces to … Update Playwright.csproj to upgrade Microsoft.Bcl.AsyncInterfaces Sep 27, 2024
@campersau
Copy link
Copy Markdown
Contributor

Is there a specific reason for this?
In my opinion libraries should use the lowest version possible since the users can override them by explicitly include the references themselves. This was also done with System.Text.Json here #2720
Also since System.Text.Json references Microsoft.Bcl.AsyncInterfaces as well, these should be kept in sync.

@Meir017
Copy link
Copy Markdown
Contributor

Meir017 commented Sep 27, 2024

I think as long as our dependencies support netstandard we should be ok updating, see https://www.nuget.org/packages/Microsoft.Bcl.AsyncInterfaces/8.0.0#supportedframeworks-body-tab
image

@RaminJolfaei
Copy link
Copy Markdown
Author

RaminJolfaei commented Sep 28, 2024

My primary reason for upgrading Microsoft.Bcl.AsyncInterfaces to version 8.0.0 is that our DevOps pipeline throws an error during the post-compile step. The pipeline checks DLL references and fails when it doesn’t find version 6 in the bin folder. To resolve this issue and ensure the pipeline can complete successfully, the upgrade to version 8 is necessary. I believe this change will not have any adverse side effects in other environments.

Additionally, most of the other packages we use are now dependent on version 8.0.0 of Microsoft.Bcl.AsyncInterfaces, making this upgrade essential for maintaining compatibility across the project.

@mxschmitt
Copy link
Copy Markdown
Contributor

Closing as per above - please start with filing an issue with reproduction steps etc. Thank you!

@mxschmitt mxschmitt closed this Nov 5, 2024
@RaminJolfaei RaminJolfaei deleted the patch-1 branch September 15, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants