[BUG] Now work mocking with route.fulfill json

[zimaev]

Context:

• Playwright Version: [Version 1.29]
• Operating System: [Windows, Mac]
• Python version: [3.10]
• Browser: [Chromium,]

Code Snippet

def test_mock_tags(page):

    def handle_route(route: Route):

        response = route.fetch()
        json = response.json()
        json["tags"] = ["implementations", "deserunt"]
        route.fulfill(json=json, response=response)


    page.route("**/api/tags", handle_route)
    page.goto('https://demo.realworld.io/')

Describe the bug
There is no mocking of json data.

[rwoll]

Thanks for the report! I was able to reproduce and find unexpected behavior:

from playwright.sync_api import Page, Route, expect

def test_unmodified(page: Page) -> None:
    page.goto("https://demo.realworld.io/")
    sidebar = page.locator('css=div.sidebar') 
    expect(sidebar.get_by_role('link')).to_contain_text(['implementations', 'welcome', 'introduction', 'codebaseShow', 'ipsum', 'qui', 'quia', 'cupiditate', 'et', 'deserunt'])

def test_intercepted(page: Page) -> None:
    def handle_route(route: Route):
        response = route.fetch()
        json = response.json()
        print("!!!!!!!!!")
        print(json)
        json["tags"] = ["implementations", "deserunt"]
        route.fulfill(json=json, response=response)

    page.route("**/api/tags", handle_route)

    page.goto("https://demo.realworld.io/")
    sidebar = page.locator('css=div.sidebar') 
    expect(sidebar.get_by_role('link')).to_contain_text(["implementations", "deserunt"])

The first test passes, the second fails with:

  File "/Users/rosswollman/Desktop/1693/env/lib/python3.10/site-packages/playwright/_impl/_network.py", line 302, in fulfill
    body = json.dumps(json)
AttributeError: 'dict' object has no attribute 'dumps'

Looks like a name shadow in the code. Will investigate and add appropriate tests.

[rwoll]

PR opened with fix. This should get cherry-picked into a 1.29.X patch release.

[rwoll]

Leaving open until patch release is issued.