Skip to content

Fixing a pyee DeprecationWarning#1117

Closed
jerichokeyne wants to merge 4 commits into
microsoft:mainfrom
jerichokeyne:patch-1
Closed

Fixing a pyee DeprecationWarning#1117
jerichokeyne wants to merge 4 commits into
microsoft:mainfrom
jerichokeyne:patch-1

Conversation

@jerichokeyne
Copy link
Copy Markdown

pyee.AsyncIOEventEmitter was moved to pyee.asyncio.AsyncIOEventEmitter, so this PR just fixes two imports

pyee.AsyncIOEventEmitter was moved to pyee.asyncio.AsyncIOEventEmitter
@ghost
Copy link
Copy Markdown

ghost commented Jan 20, 2022

CLA assistant check
All CLA requirements met.

@mxschmitt
Copy link
Copy Markdown
Contributor

I think we should also bump pyee to >=9.0.0 inside setup.py and meta.yaml otherwise it would break.

@jerichokeyne
Copy link
Copy Markdown
Author

Went ahead and updated those files

@mxschmitt
Copy link
Copy Markdown
Contributor

It seems like version 9.0 is not available on conda-forge yet: https://github.com/conda-forge/pyee-feedstock/ So we need to look into this one as well. I can try to dig into it tomorrow.

@mxschmitt
Copy link
Copy Markdown
Contributor

I opened conda-forge/pyee-feedstock#15 to fix the pyee conda-forge package. Since this is only about a deprecation warning, we can wait for that a few days.

@jerichokeyne
Copy link
Copy Markdown
Author

Thanks! And, definitely no urgency needed. Just wanted to try and get this warning fixed since it comes up every time I run my test scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants