Skip to content

Revert "fix: cleanup pending route handlers on close (#1412)"#1429

Merged
pavelfeldman merged 1 commit into
microsoft:mainfrom
rwoll:revert/partial-fix
Jul 13, 2022
Merged

Revert "fix: cleanup pending route handlers on close (#1412)"#1429
pavelfeldman merged 1 commit into
microsoft:mainfrom
rwoll:revert/partial-fix

Conversation

@rwoll
Copy link
Copy Markdown
Member

@rwoll rwoll commented Jul 13, 2022

This reverts commit c8d8f4a.

  • It's not exhaustive, and running the originally reported sample on 1.22 also yields errors.
  • There are many other places where we do asyncio.create_task without awaiting from before async handlers where added, and they need to be dealt with too.
  • We likely want to either loop over all tasks in the loop (assuming we created the loop) and kill them when we exit PW ContextManager, (2) more exhaustively track the background tasks (i.e. do what we do in this patch, but wrap some more create_async callsites), or (3) something else!

Relates 1402.

@rwoll rwoll requested a review from pavelfeldman July 13, 2022 15:38
@pavelfeldman pavelfeldman merged commit 390940a into microsoft:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants