Add downstream test discrepancy reporter#167
Merged
pavelfeldman merged 2 commits intoAug 15, 2020
Merged
Conversation
Example Run and Output: ``` $ python tests/report_downstream_test_diffs.py --playwright-js-path=../playwright --api=async MISSING, MISPELLED, OR MISNAMED: async/test_accessibility.py::test_autocomplete … async/test_workers.py::test_should_have_JSHandles_for_console_logs async/test_workers.py::test_should_report_console_logs async/test_workers.py::test_should_report_errors async/test_workers.py::test_should_report_network_activity async/test_workers.py::test_should_report_network_activity_on_worker_creation Missing: 1213, Found: 105 ``` Relates microsoft#138.
Member
Author
|
Don't be alarmed by the high missing count! 🚨 A few file and test renames will get that back up quite a bit! |
rwoll
commented
Aug 12, 2020
mxschmitt
reviewed
Aug 12, 2020
Contributor
mxschmitt
left a comment
mxschmitt
left a comment
There was a problem hiding this comment.
I would move it over to the scripts directory otherwise it looks quite nice.
rwoll
commented
Aug 13, 2020
Also update normalization to be friendlier: keep digits, compress underscores, and strip trailing underscores.
mxschmitt
approved these changes
Aug 14, 2020
mxschmitt
approved these changes
Aug 14, 2020
rwoll
commented
Aug 14, 2020
Member
Author
|
@mxschmitt The when I use check_call, the script hangs on that line. |
rwoll
force-pushed
the
feature/add-test-discrepency-tool
branch
from
02af14a to
b50e46c
Compare
pavelfeldman
approved these changes
Aug 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example Run and Output:
Relates #138.