feat(roll): roll Playwright 1.3.0-next.1598476714110#180
Merged
Conversation
mxschmitt
force-pushed
the
roll/playwright
branch
3 times, most recently
from
24002fe to
52f587b
Compare
dgozman
reviewed
Aug 26, 2020
mxschmitt
force-pushed
the
roll/playwright
branch
from
52f587b to
3ccf8d2
Compare
mxschmitt
force-pushed
the
roll/playwright
branch
from
3ccf8d2 to
2861312
Compare
dgozman
approved these changes
Aug 27, 2020
mxschmitt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm quite stuck with the dispatcher logic, not sure how to proceed there since it seems like rpc client and server share some logic upstream.