fix: show config loading error #628
Conversation
dgozman
left a comment
dgozman
left a comment
There was a problem hiding this comment.
Looks kinda ugly. Can we show something like Unable to load [playwright.config.ts](link to the error location) instead?
mxschmitt
left a comment
mxschmitt
left a comment
There was a problem hiding this comment.
Instead of creating a new UI for showing config loading errors I'd instead try to redirect to the problem tab, this is what VSCode uses as their native experience. Maybe we can even focus to the actual Problem which we added or focus to the location of where the issue occurred and then VSCode will show it as red. I think marking it as red in the WebView is a good idea but I'd resist from showing the error there.
|
I couldn't find a way of programmatically opening the Problems tab on a specific problem, so implemented the "Unable to load" UI: 
|
src/settingsView.script.ts
Outdated
| continue; | ||
|
|
||
| const errorParagraph = document.createElement('p'); | ||
| errorParagraph.textContent = 'Unable to load '; |
There was a problem hiding this comment.
Since the error location might be in a different file, what about the following layout:
Config loading errors:
- <foo.ts:17>
- <bar.ts:42>
There was a problem hiding this comment.
Yeah, something along these lines.
|
had to fix a test 😩 |
This reverts commit 5c98353.
3 participants
Resolves microsoft/playwright#35544
Screen.Recording.2025-04-17.at.13.24.26.mov