[Feature] Add locator.hasAttribute()

[azad-derakhshani-GS]

There is this function element.hasAttribute but apparently it doesn't exist in the PW framework.
This would be very useful to have as there are cases where we need to check if a certain attribute is present (not its actual value as it doesn't have a value).

So it would be great if we could add locator.HasAttribute() similar to the already existing locator.getAttribute().

[radium-v]

This would be great to have built-in. As a workaround, this can be handled by adding a matcher extension:

// playwright.config.ts

expect.extend({
    async hasAttribute(recieved: Locator, attribute: string) {
        const pass = await recieved.evaluate(
            (node, attribute) => node.hasAttribute(attribute),
            attribute
        );

        return {
            message: () => `expected ${recieved} to have attribute \`${attribute}\``,
            pass,
        };
    },
});

// global.d.ts

declare global {
    namespace PlaywrightTest {
        interface Matchers<R> {
            hasAttribute(a: string): Promise<R>;
        }
    }
}

export {};

Then it works like this:

test("should have the `disabled` attribute", async ({ page }) => {
    await page.setContent("<div disabled></div>");
    const element = page.locator("div");

    await expect(element).hasAttribute("disabled");

    await expect(element).not.hasAttribute("tabindex");
});

[azad-derakhshani-GS]

Awesome, thank you I'll try that! @radium-v
One of my next tasks was to add custom assertions anyway, so this is a good place to get started.
I tried adding the custom assertion now, however it doesn't seem to work. Can you tell me where the global.d.ts should be placed? It didn't exist yet anywhere (not even in node_modules) so I created it in the PW root folder.

That said, this GitHub issue is not about expect assertions but rather about a locator accessor locator.HasAttribute() that returns a boolean value (expect doesn't return anything), so hopefully this feature makes it into the PW codebase some day. 🤞

[manucorporat]

This is specially painful at using Qwik for testing the framework rendering!

[jmuheim]

@radium-v your workaround looks great, but I can't get it to work.

I have put your code into my playwright.global.ts, but when running the tests, I get this:

josua@Josuas-M1 adg-combobox % npm run test:run

> eth-components@0.0.0 test:run
> playwright test

ReferenceError: expect is not defined
    at Object.<anonymous> (/Users/josua/Documents/Work/AccessifyMe/Kunden/ETH/adg-combobox/playwright.config.ts:111:1)

I also don't have a global.d.ts file.

[JamieVaughn]

Another pain point that this would solve is that when using .getAttribute('disabled') on a button with the disabled attr returns an empty string, but hasAttribute('disabled') returns true. The work around is awkward right now to find that.

[Romarionijim]

the hasAttrbute feature is much needed! - because sometimes I wanna check if the attribute even exist in an if statement to assert something else based on that condition! I hope this will get released soon!

[frattaro]

You know those password visibility toggles? I need it for that.

[enriqu3l]

Hi everyone, just FYI, the idea @radium-v shared about extending expect with a new matcher hasAttribute is already implemented in playwright, we currently have a matcher called expect().toHaveAttribute(), more information here:
https://playwright.dev/docs/api/class-locatorassertions#locator-assertions-to-have-attribute-2

But I do support the idea of having such functionality locator.hasAttribute(), to know if an attribute is present with out using an expect statement, as @JamieVaughn and @Romarionijim said this is helpful when you don't want to stop the execution and just take decisions based on the attribute.

[pavelfeldman]

Closing as per above.