Skip to content

[internal] locators UI feedback #18524

@dgozman

Description

@dgozman
  • CodeGen, tried on this page: https://www.amazon.com/stores/luxury/page/6A4EB0C5-23F1-4BA0-BAF3-28921A749D70

    • "selector explorer" does not recognize my language
      • getByText('shop all').last vs last()
      • getByText('shop all', {})
    • locator tooltip does not update when matching elements did not change upon locator edit
    • cycle through matches in selector explorer, scroll to them, show [1 of 2]
    • mouse-in/mouse-out clears highlight for a second when not recording and not picking selector
    • changing language has no effect on generated locator in explorer
    • no codemirror in "explorer input field"
    • "explore" does not generate frameLocator() calls
  • pw:api

    • trace-viewer.spec:575
      • selector resolved to <div class="call-line">…</div> should be "locator"
      • strict mode violation: ".call-line >> internal:text="a"i" resolved to 6 elements should call asLocator()
      • <div class="call-line">…</div> aka page.getByText('pages: 1') drop "page."
    • locator-frame.spec:231
      • frameLocator is not transformed back:
        waiting for "locator('iframe').locator('internal:control=enter-frame').getByLabel('Name')"
        waiting for "locator('body').locator('iframe').first().locator('internal:control=enter-frame').locator('button')"
  • extension:

    • "record at cursor" overrides selection
    • "pick selector", "close tab", "record at cursor" - need to click twice sometimes
    • "close all browsers" is not disabled when no browsers are open
    • enter locator in "pick selector" box, alt-tab to see the highlight and it disappears
    • "pick selector" -> "pick locator"?
    • "log calls" does not show pw:api details
    • empty actions list in webview after hibernation
    • highlight locator under cursor works without debugging when browser is open

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions